GH-5000: Tone down WARN log output for frequent, non-critical events

eclipse-rdf4j · Jun 3, 2024 · 50b0534 · 50b0534
1 parent ac2accd
commit 50b0534
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/...c/main/java/org/eclipse/rdf4j/spring/dao/support/operation/TupleQueryResultConverter.java b/...c/main/java/org/eclipse/rdf4j/spring/dao/support/operation/TupleQueryResultConverter.java
@@ -28,6 +28,7 @@
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
+import org.eclipse.rdf4j.common.exception.RDF4JException;
 import org.eclipse.rdf4j.query.BindingSet;
 import org.eclipse.rdf4j.query.TupleQueryResult;
 import org.eclipse.rdf4j.spring.dao.support.BindingSetMapper;
@@ -56,8 +57,10 @@ public void consumeResult(Consumer<TupleQueryResult> consumer) {
 		try {
 			consumer.accept(tupleQueryResult);
 		} catch (Exception e) {
-			logger.debug("Caught execption while processing TupleQueryResult", e);
-			throw mapException("Error processing TupleQueryResult", e);
+			logger.debug("Caught execption while processing TupleQueryResult: {}", e.getMessage());
+			RDF4JException mapped = mapException("Error processing TupleQueryResult", e);
+			logger.debug("Re-throwing as {} ", mapped.getClass().getSimpleName());
+			throw mapped;
 		} finally {
 			tupleQueryResult.close();
 			tupleQueryResult = null;
@@ -71,8 +74,10 @@ public <T> T applyToResult(Function<TupleQueryResult, T> function) {
 		try {
 			return function.apply(tupleQueryResult);
 		} catch (Exception e) {
-			logger.warn("Caught execption while processing TupleQueryResult", e);
-			throw mapException("Error processing TupleQueryResult", e);
+			logger.debug("Caught execption while processing TupleQueryResult: {}", e.getMessage());
+			RDF4JException mapped = mapException("Error processing TupleQueryResult", e);
+			logger.debug("Re-throwing as {} ", mapped.getClass().getSimpleName());
+			throw mapped;
 		} finally {
 			tupleQueryResult.close();
 			tupleQueryResult = null;