Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude (unneeded ?) guava transitive dependencies #2552

Closed
6 tasks done
barthanssens opened this issue Sep 29, 2020 · 4 comments
Closed
6 tasks done

Exclude (unneeded ?) guava transitive dependencies #2552

barthanssens opened this issue Sep 29, 2020 · 4 comments
Assignees
@barthanssens
Labels
M1 Fixed in milestone 1 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Milestone
3.5.0

Comments

@barthanssens
Copy link
Contributor

barthanssens commented Sep 29, 2020 •
edited
Loading

Upgrading guava (#1097) seems to introduce new dependencies that may not be necessary (or may need a CQ if they are necessary, since they are distributed in the SDK zip)

Check if we can exclude

  • failureaccess-1.0.1.jar (CQ22654)
  • listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar (CQ22657)
  • jsr305-3.0.2.jar (CQ18738)
  • checker-qual-2.11.1.jar (CQ22650)
  • error_prone_annotations-2.3.4.jar (CQ21492)
  • j2objc-annotations-1.3.jar (CQ21995)

See also google/guava#3437
@barthanssens barthanssens added the 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks label Sep 29, 2020
@barthanssens barthanssens added this to the 3.5.0 milestone Sep 29, 2020
@barthanssens barthanssens self-assigned this Sep 29, 2020
@barthanssens barthanssens added the ✋ CQ-Pending requires a CQ to be approved label Sep 29, 2020
@abrokenjester
Copy link
Contributor

Since we already did a release with these included, we'll need to get them CQ'd and approved.

@barthanssens
Copy link
Contributor Author

Ow OK... on it...

@abrokenjester
Copy link
Contributor

Thanks Bart!

barthanssens added a commit to Fedict/rdf4j that referenced this issue Oct 2, 2020
@barthanssens
eclipse-rdf4jGH-2552 exclude guava dependencies
299f8cf 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens mentioned this issue Oct 2, 2020
Merged
5 tasks
barthanssens added a commit that referenced this issue Oct 2, 2020
@barthanssens
GH-2552 exclude guava dependencies (#2573)
ceada76 
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens removed the ✋ CQ-Pending requires a CQ to be approved label Oct 5, 2020
@barthanssens
Copy link
Contributor Author

@jeenbroekstra (former) dependencies approved, so we're good :-) Only keeping 2 dependencies that seem to be sometimes required

anqit pushed a commit to anqit/rdf4j that referenced this issue Oct 20, 2020
@abrokenjester
eclipse-rdf4jGH-2522 release notes 3.4.2 (eclipse-rdf4j#2533)
64b1405 
* eclipse-rdf4jGH-2552 make release notes paginated

* eclipse-rdf4jGH-2522 release notes, news item, download links for 3.4.2
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barthanssens barthanssens

Labels
M1 Fixed in milestone 1 🛠️ tech debt code refactoring, deprecation, and other technical debt tasks
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@abrokenjester @barthanssens