Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query explanation not showing HAVING node #5134

Closed
hmottestad opened this issue Sep 24, 2024 Discussed in #5129 · 1 comment
Closed

Query explanation not showing HAVING node #5134

hmottestad opened this issue Sep 24, 2024 Discussed in #5129 · 1 comment
Assignees
@hmottestad
Labels
cannot reproduce issue can not be reproduced (close reason)
Milestone
5.1.1

Comments

@hmottestad
Copy link
Contributor

hmottestad commented Sep 24, 2024 •
edited
Loading

Discussed in #5129

SPARQL query with a HAVING node will show an incorrect query explanation because the HAVING node is not part of the query explanation. This makes it seem like the query is returning more results than expected.

Plan:

  • Make tests in QueryPlanRetrievalTest
  • Understand how the ASTHavingClause is represented using TupleExpr by taking a look at the private TupleExpr processHavingClause(ASTHavingClause havingNode, TupleExpr tupleExpr, Group group) method in TupleExprBuilder
@hmottestad hmottestad added 🐞 bug issue is a bug 📦 sparql affects the SPARQL parser / engine labels Sep 24, 2024
@hmottestad hmottestad added this to the 5.0.3 milestone Sep 24, 2024
@hmottestad hmottestad self-assigned this Sep 24, 2024
@hmottestad
Copy link
Contributor Author

May be related to: #4772

hmottestad added a commit that referenced this issue Oct 21, 2024
@hmottestad
GH-5134 add test
00f8465
@hmottestad hmottestad modified the milestones: 5.0.3, 5.0.4 Nov 10, 2024
@hmottestad hmottestad modified the milestones: 5.0.4, 5.1.1 Nov 21, 2024
@hmottestad hmottestad added cannot reproduce issue can not be reproduced (close reason) and removed 🐞 bug issue is a bug 📦 sparql affects the SPARQL parser / engine labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
cannot reproduce issue can not be reproduced (close reason)
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
1 participant
@hmottestad