Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5060: use more recent version of zookeeper to fix CVE #5062

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

barthanssens
Copy link
Contributor

GitHub issue resolved: # 5060

Briefly describe the changes proposed in this PR:

  • use a newer version of zookeeper for fix CVE

PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@barthanssens barthanssens force-pushed the GH-5060-upgrade-zookeeper branch from bdaedb0 to 3df6dc7 Compare June 28, 2024 17:00
@hmottestad
Copy link
Contributor

What version of zookeeper are we using today? And where is zoo-keeper being used do you know?

@barthanssens
Copy link
Contributor Author

What version of zookeeper are we using today? And where is zoo-keeper being used do you know?

Via solr-sorlj version 3.6.2 is used (or at least, zookeeper is distributed in the 5.0 SDK), not sure if it is actually used (i.e. started) when using the Solr Index Sail ...

@hmottestad
Copy link
Contributor

Maven is supposed to choose the highest version number when there is a conflict, so hopefully the next time we update solr then it will choose the zookeeper version from solr if it's higher.

I don't really trust that though. So maybe you can add a comment to the Pom to explain that we are only specifying the version here because solr version x.x.x has a transitive dependency for zookeeper that is has a vulnerability?

Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@barthanssens barthanssens force-pushed the GH-5060-upgrade-zookeeper branch from 131557d to 2faa3d8 Compare July 1, 2024 19:43
@barthanssens barthanssens merged commit 81eb983 into eclipse-rdf4j:main Jul 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants