Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable annotation processor by default #105

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jan 6, 2024

This closes #104

@kwin kwin requested review from cstamas and mcculls January 6, 2024 11:47
@slawekjaranowski
Copy link

Should be document how to enable without - META-INF/services/javax.annotation.processing.Processor

@mcculls
Copy link
Contributor

mcculls commented Jan 7, 2024

Should be document how to enable without - META-INF/services/javax.annotation.processing.Processor

Agree - another option would be to leave the services entry in place and use a system property to enable/disable (off by default)

@kwin
Copy link
Contributor Author

kwin commented Jan 7, 2024

use a system property to enable/disable

As this is core functionality of Javac I wouldn't introduce another toggle: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javac.html#BHCDIFEE -> option -processor <classname>. I will enrich the readme and site.

@kwin
Copy link
Contributor Author

kwin commented Jan 7, 2024

@mcculls Is https://github.com/eclipse/sisu.inject/blob/master/docs/index.html really manually crafted or created by some tool (if yes from what source)? WDYT about switching to a standardized Maven site here as well leveraging markdown?

@kwin kwin merged commit a2b578a into master Jan 30, 2024
12 checks passed
@kwin kwin deleted the feature/disable-annotation-processor branch January 30, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don’t register annotation processor
4 participants