Consolidate projects (inject, plexus, mojos) into this repository #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes #51
Using wrapper 3.3.1 and default script-only type.
Using wrapper 3.3.1 and default script-only type.
Also, apply circumventions for known issues (m-p-p). Note: spotless due Java incompatibilities is left out.
Make it same as it is in Sisu, sans Plexus dependencies that were pulled by original p-c-d (annos, utils, classworlds)
Generally updates the build to use latest Maven plugins, aligned with 3.6.3 requirement (for build). There is a "mild" update of p-u from 4.0.0 to 4.0.1. Note: spotless due Java incompatibilities is left out. bnd 7.0.0 is left out also as it has Maven prerequisite for 3.8.1 (we are at 3.6.3).
And inconsistent, as then why only this one private static method, why not all? These methods are fine to remain static as they do not depend on any instance variable. Lets undo this change (and have them all static) or, we can make them all instance methods, but remain consistent.
And up mildly (to proposed versions) the dependencies: * logback 1.2.13 This aligns with sisu.inject the dep version.
No dependency version should exist aside of the top level POM.
|
Missing: And optionally:
And then IMHO we are ready for a release. |
- gpg passphrase should not come from file (use agent or env var) - drop nexus-staging-plugin (and better do last release steps manually via UI)
|
In general looks good. Just wondering if we should disable Sonarcloud.io beforehand and use a new project for the consolidated repos instead (otherwise history is kind of confusing of https://sonarcloud.io/project/overview?id=org.eclipse.sisu%3Asisu-inject) |
|
|
Consolidation happened, main branch is now default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to "consolidate" the 3 repositories into one (this one) along with history. Idea is to have one multi module build, given all 3 repositories share same release cycle.
Changes:
mainbranchsisu.plexussisu.mojosmasterbranch, and declaremainthe main branch. Archivesisu.plexusandsisu.mojosrepositories.NOTE: This PR is not to be merged, instead, project should make the
mainbranch a default branch.