Rename release profile #133
Conversation
As we dumped nx2 staging plugin, rename the profile ID to something more logical: "sisu-release".
| @@ -456,7 +456,7 @@ | |||
|
|
|||
| <profiles> | |||
| <profile> | |||
| <id>sonatype-oss-release</id> | |||
| <id>sisu-release</id> | |||
There was a problem hiding this comment.
Why not the default profile name release?
There was a problem hiding this comment.
As it may conflict with out of the box profile, and as you see, release plugin explicitly disables it.
There was a problem hiding this comment.
Also, the release profile used by project was not "default" anyway, this PR does not change in this respect, just shortens its name (and aligns it, with other "release profiles" like apache-release or takari-release etc).
There was a problem hiding this comment.
I still don't get why we need a project-specific prefix. I like to have the same profile name across all projects, therefore I usually pick release. But as it always has been used with some prefix I am fine with keeping it.
|
As we dumped nx2 staging plugin, rename the profile ID to something more logical: "sisu-release".