Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jacoco coverage repots in Sonar #136

Merged
merged 10 commits into from
May 31, 2024
Merged

Fix Jacoco coverage repots in Sonar #136

merged 10 commits into from
May 31, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 30, 2024

Now that inject and plexus are consolidated, they should not step on each other toe, and write to top level target directory the report.

This does NOT fix Sonar, that for me, unknown reason, does not pick up generated Jacoco reports. Still, the reports on local builds are there and are usable.

Now that inject and plexus are consolidated, they should
not step on each other toe, and write to top level
target directory the report.
@cstamas cstamas added this to the 0.9.0.M3 milestone May 30, 2024
@cstamas cstamas requested review from mcculls and kwin May 30, 2024 12:22
@cstamas cstamas self-assigned this May 30, 2024
@cstamas cstamas changed the title Do not overwrite each other Fix Jacoco coverage repots in Sonar May 30, 2024
@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

So, coverage is not picked up by Sonar... unsure why 🤔

@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

Am giving up this fight with Sonar, anyone any clue?

@kwin
Copy link
Contributor

kwin commented May 30, 2024

Is this really that hard to achieve with Maven as outlined in https://github.com/jacoco/jacoco/wiki/MavenMultiModule? I think implementing a https://maven.apache.org/ref/3.9.7/maven-core/apidocs/org/apache/maven/execution/AbstractExecutionListener.html in Jacoco should allow to get rid of this additional module. WDYT @cstamas?

@kwin kwin closed this May 30, 2024
@kwin kwin reopened this May 30, 2024
@cstamas
Copy link
Member Author

cstamas commented May 30, 2024

No idea. Imho this is not jacoco (if you build locally all the files and reports are properly in place: per module reports but also the aggrgated one). It is more about sonat not picking up them, like it have clue where to look?

Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cstamas cstamas merged commit a5f51ed into main May 31, 2024
13 checks passed
@cstamas cstamas deleted the jacoco branch May 31, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants