Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge root doc page with getting started #555

Merged
merged 2 commits into from
May 15, 2024
Merged

Merge root doc page with getting started #555

merged 2 commits into from
May 15, 2024

Conversation

JonasHelming
Copy link
Contributor

fixed #554

@JonasHelming JonasHelming marked this pull request as draft May 14, 2024 21:19
@JonasHelming JonasHelming temporarily deployed to pull-request-preview May 14, 2024 21:20 — with GitHub Actions Inactive
Copy link

github-actions bot commented May 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-15 12:30 UTC

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see "Scope" and "Feedback" sections from the old /docs/ are not on the new merged page.
Links from "Feedback" are mostly available under "Need Help?" The Twitter/X link is missing however. Do we need it?
"Scope" is available in more detail under /project_goals/, so I think it is fine to not have them on the merged page.
Maybe we should keep the "Star the repository to show your support.". I am not sure if this is mentioned anywhere else on the website. Maybe under Contributing?

@JonasHelming
Copy link
Contributor Author

I addressed your two suggestions, thanks!

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonasHelming JonasHelming merged commit 502b94e into master May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge documentation root page with getting started
2 participants