Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual approach from composing application docu #621

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

JonasHelming
Copy link
Contributor

fixed #611

fixed #611

Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link

github-actions bot commented Oct 13, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-14 11:00 UTC

Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a suggestion inline. Thanks!

src/docs/authoring_extensions.md Show resolved Hide resolved
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Copy link
Contributor

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@JonasHelming JonasHelming merged commit 3f7d591 into master Oct 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[content] improve documentation guiding from 'manual json' to yeoman
2 participants