Skip to content

Commit

Permalink
Fixed DI.
Browse files Browse the repository at this point in the history
 - Reflect has to be imported to help webpack to discover it.
 - Removed obsolete Reflect dependency from the client.

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
  • Loading branch information
kittaakos committed Mar 3, 2017
1 parent 9673bf0 commit 05eeb83
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion @theia/shell-dom/src/application.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

import "reflect-metadata";

This comment has been minimized.

Copy link
@akosyakov

akosyakov Mar 3, 2017

Member

@svenefftinge Where would be the best place to import it?

This comment has been minimized.

Copy link
@svenefftinge

svenefftinge Mar 3, 2017

Contributor

Not sure, see inversify/InversifyJS#262 (comment).
Sounds like it should be done in each application. So propably index.tsof the example.

import { Application } from "@phosphor/application";
import { ApplicationShell } from "./shell";
import { injectable, multiInject } from "inversify";
Expand Down
2 changes: 0 additions & 2 deletions examples/browser/index.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<!DOCTYPE html>
<html>
<head>

<link href="http://maxcdn.bootstrapcdn.com/font-awesome/4.2.0/css/font-awesome.min.css" rel="stylesheet">
<script type="text/javascript" src="./../../node_modules/reflect-metadata/Reflect.js"></script>
<script type="text/javascript" src="https://www.promisejs.org/polyfills/promise-6.1.0.js"></script>
<script type="text/javascript" src="lib/web/bundle.js"></script>
</head>
Expand Down

0 comments on commit 05eeb83

Please sign in to comment.