ensure all files present in filters

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
eclipse-theia · Jun 22, 2020 · a6ced80 · a6ced80
1 parent 52a43ce
commit a6ced80
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/filesystem/src/browser/file-dialog/file-dialog-tree-filters-renderer.tsx b/packages/filesystem/src/browser/file-dialog/file-dialog-tree-filters-renderer.tsx
@@ -36,11 +36,14 @@ export class FileDialogTreeFilters {
 
 export class FileDialogTreeFiltersRenderer extends ReactRenderer {
 
+    readonly filters: FileDialogTreeFilters;
+
     constructor(
-        readonly filters: FileDialogTreeFilters,
+        filters: FileDialogTreeFilters,
         readonly fileDialogTree: FileDialogTree
     ) {
         super();
+        this.filters = { 'All Files': [], ...filters, };
     }
 
     protected readonly handleFilterChanged = (e: React.ChangeEvent<HTMLSelectElement>) => this.onFilterChanged(e);
@@ -50,12 +53,7 @@ export class FileDialogTreeFiltersRenderer extends ReactRenderer {
             return undefined;
         }
 
-        const fileTypes = ['All Files'];
-        Object.keys(this.filters).forEach(element => {
-            fileTypes.push(element);
-        });
-
-        const options = fileTypes.map(value => this.renderLocation(value));
+        const options = Object.keys(this.filters).map(value => this.renderLocation(value));
         return <select className={'theia-select ' + FILE_TREE_FILTERS_LIST_CLASS} onChange={this.handleFilterChanged}>{...options}</select>;
     }