Skip to content

Commit

Permalink
about: dialog does not display correctly when re-opened
Browse files Browse the repository at this point in the history
Fixes: #7129
The help dialog was not rendering the list of extensions, hence functionality was added to display the list even after it being closed once.

Signed-off-by: Muhammad Anas Shahid <muhammad.shahid@ericsson.com>
  • Loading branch information
Muhammad Anas Shahid committed Feb 12, 2020
1 parent 46a2d51 commit c253522
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions packages/core/src/browser/dialogs/react-dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ export abstract class ReactDialog<T> extends AbstractDialog<T> {
ReactDOM.render(<>{this.render()}</>, this.contentNode, () => this.onRender.dispose());
}

protected onAfterAttach(msg: Message): void {
super.onAfterAttach(msg);
this.update();
}

protected onActivateRequest(msg: Message): void {
super.onActivateRequest(msg);
this.update();
}

/**
* Render the React widget in the DOM.
* - If the widget has been previously rendered,
Expand Down

0 comments on commit c253522

Please sign in to comment.