[debug] debug-ext prematurely fires didStart event on didCreate

[kittaakos]

Bug Description:

As the title says, the debug-ext will incorrectly fire the didStart event, on didCreate and will call the debug adapter. It's too early.

theia/packages/plugin-ext/src/plugin/debug/debug-ext.ts

Lines 248 to 253 in b58de21

	async $sessionDidCreate(sessionId: string): Promise<void> {
	const session = this.sessions.get(sessionId);
	if (session) {
	this.onDidStartDebugSessionEmitter.fire(session);
	}
	}

Some debug adapters will run custom DAP requests on session start, such as the cortex-debug extension here, and will break, as the session has not been initialized yet.

2022-11-24T13:19:18.818Z root ERROR [hosted-plugin: 30330] /Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:16423
            if (this.serverController.customRequest(command, response, args)) {
                                      ^

TypeError: Cannot read properties of undefined (reading 'customRequest')
    at GDBDebugSession.<anonymous> (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:16423:39)
    at Generator.next (<anonymous>)
    at /Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:15519:71
    at new Promise (<anonymous>)
    at __webpack_modules__../src/gdb.ts.__awaiter (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:15515:12)
    at GDBDebugSession.customRequest (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:16418:16)
    at GDBDebugSession.dispatchRequest (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:515:22)
    at GDBDebugSession.dispatchRequest (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:1183:15)
    at GDBDebugSession.handleMessage (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:1364:18)
    at GDBDebugSession._handleData (/Users/a.kitta/dev/git/theia/plugins/cortex-debug/extension/dist/debugadapter.js:1458:34)

Steps to Reproduce:

1. Get the 1.5.1 cortex-debug VSIX from my fork: https://github.com/kittaakos/cortex-debug/raw/1.5.1/marus25.cortex-debug-1.5.1-development.vsix
2. Configure the debug session based on the official documentation: https://github.com/Marus/cortex-debug#installation
3. Start the debug session

Additional Information

• Operating System: macOS 12.5.1
• Theia Version: 1.31.1

[kittaakos]

Please assign this to me. Thanks!