Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using msgpackr@^1.9.0 causes maximum call stack exceeded error #12499

Closed
paul-marechal opened this issue May 8, 2023 · 3 comments
Closed

Using msgpackr@^1.9.0 causes maximum call stack exceeded error #12499

paul-marechal opened this issue May 8, 2023 · 3 comments
Labels
dependencies pull requests that update a dependency file

Comments

@paul-marechal
Copy link
Member

paul-marechal commented May 8, 2023

From #12484 (comment)

image

@paul-marechal
Copy link
Member Author

paul-marechal commented Jun 6, 2023

Fix: kriszyp/msgpackr#117

The cause is a bit weird... Sometimes we send monaco types directly to mspackr instead of clean DTOs. Said type returns this in its toJSON method which sends msgpackr into a recursion loop. I don't really understand why monaco types do that, we could also try to make sane DTOs before sending them. I opted for proposing a patch in msgpackr to handle this odd case more gracefully.

@paul-marechal
Copy link
Member Author

The fix is now merged and released in msgpackr@1.9.5, we'll need to update our docs to tell people to update :)

@msujew
Copy link
Member

msujew commented Jun 4, 2024

We are now using 1.10.2, which works without any hiccups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants