bug: maximum callstack exceeded errors due to msgpackr

[vince-fugnitto]

Bug Description:

There is an issue following 6ddc6e3 where the upgrade to msgpackr is causing maximum callstack exceeded errors due to eclipse-theia/theia#12499. We added a resolution note in the main repo as a workaround until fixed:

• https://github.com/eclipse-theia/theia/blob/master/doc/Migration.md#general

rpc-message-encoder.ts:151 Uncaught (in promise) Error: Error during encoding: 'Maximum call stack size exceeded'
    at t.MsgPackMessageEncoder.encode (rpc-message-encoder.ts:151:23)
    at t.MsgPackMessageEncoder.request (rpc-message-encoder.ts:137:14)
    at l.sendRequest (rpc-protocol.ts:161:22)
    at proxy-handler.ts:74:45

theia-blueprint/yarn.lock

Lines 9567 to 9568 in 5850adb

	msgpackr@^1.6.1:
	version "1.9.0"

Steps to Reproduce:

1. start the application
2. notice the maximum callstack exceeded logs

Additional Info

• Exception thrown when using Theia Blueprint 1.37 theia#12574

[badrihcl]

The mentioned workaround works and exception isn't thrown . But we still have the connection issue as mentioned in eclipse-theia/theia#12574.

The issue occurs only with Theia Blueprint 1.37 and not with Theia Blueprint 1.36 for the same vscode extension.

Should I raise a separate defect for this ?

[vince-fugnitto]

@badrihcl I don't have an environment to test, if you can debug as to why it happens first that would be helpful.

[marcdumais-work]

@badrihcl Can you try with Blueprint 1.38.0, that we recently made available? It pins msgpackr to an earlier version, known to work.

Also, it seems that msgpackr has a new version out that contains a fix: 1.9.5. Let us know if you still have the issue with Blueprint 1.38.0, and maybe we can upgrade its msgpackr.