-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theia does not respect StoppedEvent description in Debug Adapter Protocol #13049
Comments
@EvilBeaver Are you interested in contributing a fix for this? |
@msujew yes, I can fix it |
@msujew one question: where translations are stored in the codebase?
|
@EvilBeaver You can find all translation files here, with the requested key in particular here. Note that these are initially machine translated, though manual improvements to the translations are welcome. |
If stopped event description exists it must be shown in UI as is.
…3049 If thread Stopped event contains description field, UI must show description as is
Bug Description:
Theia does not use Description field of event, thus text "Paused on {0}" can't be properly localized
https://microsoft.github.io/debug-adapter-protocol/specification#Events_Stopped
Steps to Reproduce:
https://github.com/eclipse-theia/theia/blob/master/packages/debug/src/browser/model/debug-thread.tsx#L233
In code above there is a localization of the reason, but there are two bad things here:
Expected behavior
Theia respects
description
field and if it exists - shows it AS IS without any prefixes, as required by DAP.Additional Information
The text was updated successfully, but these errors were encountered: