Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New File doesn't accept a filename #13303

Closed
Tracked by #13192
profbbrown opened this issue Jan 23, 2024 · 3 comments · Fixed by #13344
Closed
Tracked by #13192

New File doesn't accept a filename #13303

profbbrown opened this issue Jan 23, 2024 · 3 comments · Fixed by #13344
Milestone

Comments

@profbbrown
Copy link

Bug Description:

Selecting New File... from the File menu brings up a selection box prompting the user to "Select file type or enter file name." However, entering a filename doesn't do anything. The box disappears and no new editor is opened.

Additional Information

  • Operating System: MacOS Sonoma, Chrome browser
  • Theia Version: 1.45

Extensions loaded:

@theia/callhierarchy 1.45.0
@theia/console 1.45.0
@theia/core 1.45.0
@theia/debug 1.45.0
@theia/editor 1.45.0
@theia/editor-preview 1.45.0
@theia/file-search 1.45.0
@theia/filesystem 1.45.0
@theia/getting-started 1.45.0
@theia/git 1.45.0
@theia/keymaps 1.45.0
@theia/markers 1.45.0
@theia/messages 1.45.0
@theia/metrics 1.45.0
@theia/mini-browser 1.45.0
@theia/monaco 1.45.0
@theia/navigator 1.45.0
@theia/notebook 1.45.0
@theia/outline-view 1.45.0
@theia/output 1.45.0
@theia/plugin-dev 1.45.0
@theia/plugin-ext 1.45.0
@theia/plugin-ext-vscode 1.45.0
@theia/plugin-metrics 1.45.0
@theia/preferences 1.45.0
@theia/preview 1.45.0
@theia/process 1.45.0
@theia/property-view 1.45.0
@theia/scm 1.45.0
@theia/scm-extra 1.45.0
@theia/search-in-workspace 1.45.0
@theia/task 1.45.0
@theia/terminal 1.45.0
@theia/timeline 1.45.0
@theia/toolbar 1.45.0
@theia/typehierarchy 1.45.0
@theia/userstorage 1.45.0
@theia/variable-resolver 1.45.0
@theia/vsx-registry 1.45.0
@theia/workspace 1.45.0
@JonasHelming JonasHelming mentioned this issue Jan 24, 2024
55 tasks
@dhuebner
Copy link
Member

dhuebner commented Feb 2, 2024

@profbbrown @JonasHelming

However, entering a filename doesn't do anything.

vs-code opens a new system explorer window, because normally this command is called from the Welcome page. Creating a new file directly in the workspace would need an additional validation to check if the file already exists.

What do you expect to happen in Theia?

@profbbrown
Copy link
Author

Clicking the small "new file" icon in the Explorer heading prompts for a filename and then opens an editor for it. I expected that the menu item "New File" would do something similar: I'll type in a filename and an editor will open for it.

@dhuebner
Copy link
Member

@profbbrown @JonasHelming
PR #13344 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants