VS Code Extensions: Using submenus as "view/title" menu does not work

[chroberino]

Bug Description:

When using a submenu as a "view/title" in a VS Code extension manifest (package.json) the menu items are defunct, i.e. they have no effect when clicking on them. In VS Code the same approach is working fine.

Steps to Reproduce:

1. Install the Gitlens VS Code extension (eamodio.gitlens) in Theia.
2. Open the Gitlens Inspect view and navigate to "Search & Compare"
3. Click on the "plus" icon button (the chevron-down overlay hints there is a submenu, see screenshot).
4. Click on either action there, it will not have any effect (in VS Code these commands trigger the command prompt)
   

Note

The basic approach in package.json is as follows:

	"submenus": [
		{
			"icon": "$(add)",
			"label": "Add",
			"id": "add_submenu_id"
		}
	],
	"menus": {
		"view/title": [
			{
				"submenu": "add_submenu_id",
				"when": "view == my_custom_view_id",
				"group": "navigation"
			}
		],

		"add_submenu_id": [
			{
				"command": "command_id_0"
			},
			{
				"command": "command_id_1"
			}
		]
	}

(copied from the comments section of this article: https://www.eliostruyf.com/creating-submenu-code-step-step-guide/)

Additional Information

• Operating System: Windows 10
• Theia Version: 1.49.1 (self-built browser app)

[msujew]

This should probably be a part of #13051.

[jonah-iden]

The problem comes from the renderPopupMenumethod in tab-bar-toolbar.ts:360. We are adding the current active widget as an argument for all commands even those contributed by extensions. The current widget can of course not be serialized so it runs into an maximum call stack size exceeded error.

Not sure what commands rely on this current widget being part of the commands args.
Does anyone know if we can just remove this or do we need a more complicated mechanism to distinguish between bakcend and frontend commands?

[tsmaeder]

tab-toolbar.ts#executeCommand has code that adapts the arguments (this.commandExecutor) to send and empty array. However, this code is not invoked when the item in question is in a contributed submenu. T.b.h, I think the whole affair would be simpler if the different argument adapters would be handled where we handle the menu contributions instead of doing it at invocation time.

[tsmaeder]

This disable any action in contributed toolbar drop-down. I believe we should address this issue in a timely fashion. A fix should not take more than 2 days.