Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alive check is spamming network tab in the dev tools #1490

Closed
akosyakov opened this issue Mar 13, 2018 · 1 comment · Fixed by #2222
Closed

alive check is spamming network tab in the dev tools #1490

akosyakov opened this issue Mar 13, 2018 · 1 comment · Fixed by #2222
Assignees
@svenefftinge

Comments

@akosyakov
Copy link
Member

We could consider using ws ping/pong instead.
@ishitatsuyuki
Copy link
Contributor

Another thing is that alive checking takes nontrivial amount of network resources. The period should be reduced to 10 seconds, or even 1 minute.

@svenefftinge svenefftinge self-assigned this Jun 27, 2018
svenefftinge added a commit that referenced this issue Jun 28, 2018
@svenefftinge
[connection-status] Use Websockets
ef3e988 
Changed the connection status service to use websockets
and natural activity. (fixes #1490)
@svenefftinge svenefftinge mentioned this issue Jun 28, 2018
Merged
svenefftinge added a commit that referenced this issue Jun 28, 2018
@svenefftinge
[connection-status] Use Websockets
83b753c 
Changed the connection status service to use websockets
and natural activity. (fixes #1490)

Signed-off-by: svenefftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Jun 28, 2018
@svenefftinge
[connection-status] Use Websockets
01c661f 
Changed the connection status service to use websockets
and natural activity. (fixes #1490)

Signed-off-by: svenefftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Jun 28, 2018
@svenefftinge
[connection-status] Use Websockets
4e37608 
Changed the connection status service to use websockets
and natural activity. (fixes #1490)

Signed-off-by: svenefftinge <sven.efftinge@typefox.io>
svenefftinge added a commit that referenced this issue Jun 28, 2018
@svenefftinge
[connection-status] Use Websockets
3fbd5e5 
Changed the connection status service to use websockets
and natural activity. (fixes #1490)

Signed-off-by: svenefftinge <sven.efftinge@typefox.io>
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
@svenefftinge @marcdumais-work
[connection-status] Use Websockets
27b4056 
Changed the connection status service to use websockets
and natural activity. (fixes eclipse-theia#1490)

Signed-off-by: svenefftinge <sven.efftinge@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenefftinge svenefftinge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[connection-status] Use Websockets eclipse-theia/theia
4 participants
@svenefftinge @akosyakov @ishitatsuyuki @marcdumais-work