Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[file-search] The file search looks different on Windows and OS X #1591

Closed
2 tasks
kittaakos opened this issue Mar 28, 2018 · 3 comments · Fixed by #6029
Closed
2 tasks

[file-search] The file search looks different on Windows and OS X #1591

kittaakos opened this issue Mar 28, 2018 · 3 comments · Fixed by #6029
Labels
bug bugs found in the application file search issues related to the file search help wanted issues meant to be picked up, require help OS/Windows issues related to the Windows OS

Comments

@kittaakos
Copy link
Contributor

Depends on #1584.

Once the file search works on Windows and OS X, one has to check why the UI looks different on Windows than OS X. Originally from here

AC:

  • The quick file search should look the same on all platforms.
  • It should not show encoded URI segments: %40phosphor instead of @phosphor.

Hint: one has to check whether we send URIs (as strings) back and forth between the frontend and the backend instead of FS paths.

OS X:
screen shot 2018-03-27 at 18 42 59

Windows:
screen shot 2018-03-27 at 18 43 09

@kittaakos kittaakos added help wanted issues meant to be picked up, require help file search issues related to the file search labels Mar 28, 2018
@kittaakos kittaakos added the OS/Windows issues related to the Windows OS label Aug 31, 2018
@akosyakov
Copy link
Member

Looks like results returned by the search are normalized via URI.

@akosyakov akosyakov added the bug bugs found in the application label Aug 31, 2018
@kittaakos
Copy link
Contributor Author

No, the picture is out-dated, the URI normalization is already fixed. The catch is; on Windows, it is a path, on OS X it is the file name and the relative path as a description.

@elaihau
Copy link
Contributor

elaihau commented Dec 20, 2018

could we close this one as #3749 was merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application file search issues related to the file search help wanted issues meant to be picked up, require help OS/Windows issues related to the Windows OS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants