Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[windows] Workspace search is broken #1584

Closed
kittaakos opened this issue Mar 27, 2018 · 5 comments · Fixed by #1587
Closed

[windows] Workspace search is broken #1584

kittaakos opened this issue Mar 27, 2018 · 5 comments · Fixed by #1587
Assignees
@kittaakos
Labels
bug bugs found in the application file search issues related to the file search OS/Windows issues related to the Windows OS

Comments

@kittaakos
Copy link
Contributor

Ctrl+P does not return anything in Theia.

[2018-03-27T06:52:27.814Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Request find failed with error: spawn C:\Users\kittaako
s\dev\theia\node_modules\vscode-ripgrep\bin\rg ENOENT [ 'Error: spawn C:\\Users\\kittaakos\\dev\\theia\\node_modules\\vs
code-ripgrep\\bin\\rg ENOENT\n    at exports._errnoException (util.js:1024:11)\n    at Process.ChildProcess._handle.onex
it (internal/child_process.js:192:19)\n    at onErrorNT (internal/child_process.js:374:16)\n    at _combinedTickCallback
 (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)' ]

[2018-03-27T06:52:27.914Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Error: spawn C:\Users\kittaakos\dev\theia\node_modules\
vscode-ripgrep\bin\rg ENOENT [] (module=process)

[2018-03-27T06:52:27.914Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Request find failed with error: spawn C:\Users\kittaako
s\dev\theia\node_modules\vscode-ripgrep\bin\rg ENOENT [ 'Error: spawn C:\\Users\\kittaakos\\dev\\theia\\node_modules\\vs
code-ripgrep\\bin\\rg ENOENT\n    at exports._errnoException (util.js:1024:11)\n    at Process.ChildProcess._handle.onex
it (internal/child_process.js:192:19)\n    at onErrorNT (internal/child_process.js:374:16)\n    at _combinedTickCallback
 (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)' ]

[2018-03-27T06:52:29.644Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Error: spawn C:\Users\kittaakos\dev\theia\node_modules\
vscode-ripgrep\bin\rg ENOENT [] (module=process)

[2018-03-27T06:52:29.644Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Request find failed with error: spawn C:\Users\kittaako
s\dev\theia\node_modules\vscode-ripgrep\bin\rg ENOENT [ 'Error: spawn C:\\Users\\kittaakos\\dev\\theia\\node_modules\\vs
code-ripgrep\\bin\\rg ENOENT\n    at exports._errnoException (util.js:1024:11)\n    at Process.ChildProcess._handle.onex
it (internal/child_process.js:192:19)\n    at onErrorNT (internal/child_process.js:374:16)\n    at _combinedTickCallback
 (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)' ]

[2018-03-27T06:52:29.789Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Error: spawn C:\Users\kittaakos\dev\theia\node_modules\
vscode-ripgrep\bin\rg ENOENT [] (module=process)

[2018-03-27T06:52:29.789Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Request find failed with error: spawn C:\Users\kittaako
s\dev\theia\node_modules\vscode-ripgrep\bin\rg ENOENT [ 'Error: spawn C:\\Users\\kittaakos\\dev\\theia\\node_modules\\vs
code-ripgrep\\bin\\rg ENOENT\n    at exports._errnoException (util.js:1024:11)\n    at Process.ChildProcess._handle.onex
it (internal/child_process.js:192:19)\n    at onErrorNT (internal/child_process.js:374:16)\n    at _combinedTickCallback
 (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)' ]

[2018-03-27T06:52:29.939Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Error: spawn C:\Users\kittaakos\dev\theia\node_modules\
vscode-ripgrep\bin\rg ENOENT [] (module=process)

[2018-03-27T06:52:29.940Z] ERROR: Theia/4568 on DESKTOP-VJRAMKC: Request find failed with error: spawn C:\Users\kittaako
s\dev\theia\node_modules\vscode-ripgrep\bin\rg ENOENT [ 'Error: spawn C:\\Users\\kittaakos\\dev\\theia\\node_modules\\vs
code-ripgrep\\bin\\rg ENOENT\n    at exports._errnoException (util.js:1024:11)\n    at Process.ChildProcess._handle.onex
it (internal/child_process.js:192:19)\n    at onErrorNT (internal/child_process.js:374:16)\n    at _combinedTickCallback
 (internal/process/next_tick.js:138:11)\n    at process._tickCallback (internal/process/next_tick.js:180:9)' ]
@kittaakos kittaakos added bug bugs found in the application OS/Windows issues related to the Windows OS file search issues related to the file search labels Mar 27, 2018
@kittaakos
Copy link
Contributor Author

It should be rg.exe on Windows.

screen shot 2018-03-27 at 09 04 53

@kittaakos
Copy link
Contributor Author

I have looked into it, changed the command path to .exe on Windows. If I execute the following, the suffixed command path exists.

require('fs').existsSync(command)
true

But when spawning the process it fails because cannot locate the executable. Could it be related to the rootPath?
Currently, the rootPath is "/c:/Users/kittaakos/dev/theia" on my image and look at this:

require('fs').existsSync(opts.rootPath)
false

Do you have any hints on the path, @akosyakov?

@kittaakos
Copy link
Contributor Author

These are the two places where we have to change the path

And it should be fixed here: https://github.com/theia-ide/theia/blob/e41a77e57de7f5948e3c61cfe5f5f724b6e2fac1/packages/file-search/src/browser/quick-file-open.ts#L57

My problem is rather, is it safe at all to use our path? It cannot be just substituted with the desired FS path on Windows. Please advise.

@kittaakos
Copy link
Contributor Author

I think it would be much better to change the rootPath to rootUri and pass the URI as a string to the backend and the backend can resolve it with FsUri.fsPath(rootUri) just as we do in other places: FS, Git.

kittaakos added a commit that referenced this issue Mar 27, 2018
@kittaakos
GH-1584: Fixed file search in Windows.
1b13fdf 
 - Fixed `rigrep` path. It did not have the `.exe` suffix on Windows.
 - Fixed the `rootPath`.
 - Replaced it with a URI, so that backend can resolve it.

Closes #1584

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos
Copy link
Contributor Author

It should be rg.exe on Windows.

roblourens/vscode-ripgrep#10

kittaakos added a commit that referenced this issue Mar 27, 2018
@kittaakos
GH-1584: Fixed file search in Windows.
479ac6c 
 - Fixed `rigrep` path. It did not have the `.exe` suffix on Windows.
 - Fixed the `rootPath`.
 - Replaced it with a URI, so that backend can resolve it.
 - Enabled the search service tests. Set the failing Git ignored test to pending.

Closes #1584

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
This was referenced Mar 27, 2018
Merged
Open
kittaakos added a commit that referenced this issue Mar 27, 2018
@kittaakos
GH-1584: Fixed the file search issue on Windows.
b96bc80 
 - Updated to the most recent `vscode-ripgrep` version. It fixes the `.exe` issue on Windows.
 - Fixed the `rootPath`.
 - Replaced it with a URI, so that backend can resolve it.
 - Enabled the search service tests. Set the failing Git ignored test to pending.
 - Got rid of the obsolete type definitions.

Closes #1584

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos kittaakos mentioned this issue Mar 28, 2018
Closed
2 tasks
@kittaakos kittaakos self-assigned this Mar 28, 2018
kittaakos added a commit that referenced this issue Apr 1, 2018
@kittaakos
GH-1584: Fixed the file search issue on Windows.
3905a19 
 - Updated to the most recent `vscode-ripgrep` version. It fixes the `.exe` issue on Windows.
 - Fixed the `rootPath`.
 - Replaced it with a URI, so that backend can resolve it.
 - Enabled the search service tests. Set the failing Git ignored test to pending.
 - Got rid of the obsolete type definitions.

Closes #1584

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
kittaakos added a commit that referenced this issue Apr 1, 2018
@kittaakos
GH-1584: Fixed the file search issue on Windows.
eb1ab0b 
 - Updated to the most recent `vscode-ripgrep` version. It fixes the `.exe` issue on Windows.
 - Fixed the `rootPath`.
 - Replaced it with a URI, so that backend can resolve it.
 - Enabled the search service tests. Set the failing Git ignored test to pending.
 - Got rid of the obsolete type definitions.

Closes #1584

Signed-off-by: Akos Kitta <kittaakos@gmail.com>
@kittaakos kittaakos mentioned this issue May 15, 2018
Merged
@kittaakos kittaakos mentioned this issue Sep 7, 2018
Merged
@sunix sunix mentioned this issue Feb 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
bug bugs found in the application file search issues related to the file search OS/Windows issues related to the Windows OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-1584: Fixed file search in Windows. eclipse-theia/theia
1 participant
@kittaakos