Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigator] disturbing scroll behavior on selection #1593

Closed
JanKoehnlein opened this issue Mar 28, 2018 · 5 comments · Fixed by #8154
Closed

[navigator] disturbing scroll behavior on selection #1593

JanKoehnlein opened this issue Mar 28, 2018 · 5 comments · Fixed by #8154
Assignees
@akosyakov
Labels
help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience

Comments

@JanKoehnlein
Copy link
Contributor

In some situations (after expanding / collapsing / scrolling a larger tree for a while) selection scrolls the selected element away. This makes it almost impossible to open an unselected element.

screencast 2018-03-28 08-54-44
@JanKoehnlein
Copy link
Contributor Author

Reloading the page might also be involved to reproduce

@jbicker jbicker self-assigned this Apr 4, 2018
@jbicker jbicker closed this as completed Apr 9, 2018
@jbicker
Copy link
Contributor

jbicker commented Apr 9, 2018

Can't reproduce.

@JanKoehnlein JanKoehnlein mentioned this issue Jun 8, 2018
Closed
@kittaakos
Copy link
Contributor

Can't reproduce.

It happens only when you have "manually" scrolled. See: #3347

@kittaakos kittaakos reopened this Dec 21, 2018
@vince-fugnitto
Copy link
Member

@jbicker I tried to look into the issue but could not find a proper solution, perhaps you'd know more.
Unfortunately the odd scroll behavior is one of the more annoying usability glitches in Theia 😞

@akosyakov
Copy link
Member

akosyakov commented Jul 25, 2019 •
edited
Loading

I think there is a race when we updated rows to render and a selected row, so sometimes it goes out of sync and something bogusly selected. It is just a guess, someone has to verify.

@akosyakov akosyakov added help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience labels Jul 25, 2019
@akosyakov akosyakov mentioned this issue Aug 16, 2019
Closed
@akosyakov akosyakov self-assigned this Aug 16, 2019
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 8, 2020
[tree] fix scroll behavior when selecting or expanding a node
4d77ae8 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

Addressed the issue where the scroll jumps up when manually scrolled and
selected a node

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
@Anasshahidd21 Anasshahidd21 mentioned this issue Jul 8, 2020
Merged
1 task
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 9, 2020
[tree] fix scroll behavior when selecting or expanding a node
087d3fb 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

Addressed the issue where the scroll jumps up when manually scrolled and
selected a node.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 9, 2020
[tree] fix scroll behavior when selecting or expanding a node
13b1492 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

Addressed the issue where the scroll jumps up when manually scrolled and
selected a node.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 9, 2020
[tree] fix scroll behavior when selecting or expanding a node
d67005f 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

The commit addresses an issue with the update tree-widgets after
performing a manual scroll and selecting a tree node causing a poor user
experience.
The fix modifies the logic of the `forceUpdate` to use `clear` instead
of `clearAll` to clear the cache for only the row that is modified and
not the entire cache.

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 10, 2020
[tree] fix scroll behavior when selecting or expanding a node
d1768cf 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

The following commit updates the tree-widget to fix an issue when trees are manually scrolled and nodes are selected causing a jump (poor user-experience).
The changes include:
- updating the default resize parameter for forceUpdate to false since we only want to clear the entire cache when a resize actually occurs
- updates the onResize to properly resize when performing a forceUpdate

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 15, 2020
[tree] fix scroll behavior when selecting or expanding a node
12ec6bc 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

The following commit updates the tree-widget to fix an issue when trees are manually scrolled and nodes are selected causing a jump (poor user-experience).
The changes include:
- updating the default resize parameter for forceUpdate to false since we only want to clear the entire cache when a resize actually occurs
- updates the onResize to properly resize when performing a forceUpdate

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Anasshahidd21 pushed a commit to Anasshahidd21/theia that referenced this issue Jul 20, 2020
[tree] fix scroll behavior when selecting or expanding a node
fd1bf81 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

The following commit updates the tree-widget to fix an issue when trees are manually scrolled and nodes are selected causing a jump (poor user-experience).
The changes include:
- updating the default resize parameter for forceUpdate to false since we only want to clear the entire cache when a resize actually occurs
- updates the onResize to properly resize when performing a forceUpdate

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto pushed a commit that referenced this issue Jul 23, 2020
@vince-fugnitto
[tree] fix scroll behavior when selecting or expanding a node
da73ae1 
Fixes: #3347
Fixes: #1593

The following commit updates the tree-widget to fix an issue when trees are manually scrolled and nodes are selected causing a jump (poor user-experience).
The changes include:
- updating the default resize parameter for forceUpdate to false since we only want to clear the entire cache when a resize actually occurs
- updates the onResize to properly resize when performing a forceUpdate

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
minyoungyang pushed a commit to minyoungyang/theia that referenced this issue Aug 4, 2020
@minyoungyang
[tree] fix scroll behavior when selecting or expanding a node
6befce6 
Fixes: eclipse-theia#3347
Fixes: eclipse-theia#1593

The following commit updates the tree-widget to fix an issue when trees are manually scrolled and nodes are selected causing a jump (poor user-experience).
The changes include:
- updating the default resize parameter for forceUpdate to false since we only want to clear the entire cache when a resize actually occurs
- updates the onResize to properly resize when performing a forceUpdate

Signed-off-by: Anas Shahid <muhammad.shahid@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
help wanted issues meant to be picked up, require help tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tree] fix scroll behavior when selecting or expanding a node Anasshahidd21/theia
5 participants
@JanKoehnlein @kittaakos @akosyakov @jbicker @vince-fugnitto