Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug adapter executable resolved against the bogus plugin path #4036

Closed
akosyakov opened this issue Jan 12, 2019 · 0 comments
Closed

debug adapter executable resolved against the bogus plugin path #4036

akosyakov opened this issue Jan 12, 2019 · 0 comments
Assignees
@akosyakov
Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system

Comments

@akosyakov
Copy link
Member

akosyakov commented Jan 12, 2019 •
edited
Loading

https://github.com/theia-ide/theia/blob/5da05edeecd33f18c28686ff741a5a13d3654bc0/packages/plugin-ext/src/plugin/node/debug/debug.ts#L268

In my case debug type node2, but the executable is resolved bogusly in the context of debug-node VS Code extension. Reproducible with debug-auto-launch, debug-node and debug-node2 extensions.
@akosyakov akosyakov added bug bugs found in the application plug-in system issues related to the plug-in system debug issues that related to debug functionality labels Jan 12, 2019
@akosyakov akosyakov self-assigned this Jan 12, 2019
akosyakov added a commit that referenced this issue Jan 14, 2019
@akosyakov
[plugin] fix #4036: resolve debug executable against the correct plugin
e5d2b93 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Jan 14, 2019
Merged
akosyakov added a commit that referenced this issue Jan 14, 2019
@akosyakov
[plugin] fix #4036: resolve debug executable against the correct plugin
47157f7 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 14, 2019
@akosyakov
[plugin] fix #4036: resolve debug executable against the correct plugin
1a52050 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Jan 16, 2019
@akosyakov
[plugin] fix #4036: resolve debug executable against the correct plugin
56de289 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application debug issues that related to debug functionality plug-in system issues related to the plug-in system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov