Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vscode scm api #4103

Closed
akosyakov opened this issue Jan 18, 2019 · 14 comments · Fixed by #5416
Closed

support vscode scm api #4103

akosyakov opened this issue Jan 18, 2019 · 14 comments · Fixed by #5416
Assignees
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Jan 18, 2019

APIs: https://code.visualstudio.com/api/references/vscode-api#scm

There is VS Code extension for Git: https://github.com/Microsoft/vscode/tree/master/extensions/git

Our SCM UI is bound to Git right now. We need to extract Git-agnostic UI to a new extension. This extension should provide APIs similar to VS Code. Git extension has to be updated to use this API. The plugin extension then should use new API to implement VS Code SCM API.

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves git issues related to git vscode issues related to VSCode compatibility labels Jan 18, 2019
@vinokurig
Copy link
Contributor

Hi, is it expected to be in progress in the nearest time? We need it to launch VsCode pull request plugin: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github

@vinokurig
Copy link
Contributor

If not we can take it, @akosyakov @svenefftinge WDYT?

@vinokurig
Copy link
Contributor

The deadline for our related task (eclipse-che/che#11867) is 5-th February

@svenefftinge
Copy link
Contributor

Nice, please go ahead if you can start working on it now. :)

@sunix
Copy link
Contributor

sunix commented Jan 22, 2019

Hi I am wondering if it is possible / good strategy to reuse vscode git extension and completely replace the current theia git implementation. WDYT ?

@vinokurig
Copy link
Contributor

@sunix As far as I understood this issue is about supporting scm Plugin-Api. I think it is better to discuss such questions in #3815 or #3956

@akosyakov
Copy link
Member Author

Hi I am wondering if it is possible / good strategy to reuse vscode git extension and completely replace the current theia git implementation. WDYT ?

Eventually, maybe, if there won't be any clients. Before it the current git extension and git VS Code extension should share the same UI and contribution points.

@vinokurig
Copy link
Contributor

I guess it depends on #3423

@akosyakov
Copy link
Member Author

@vinokurig It is another way around.

@vinokurig
Copy link
Contributor

May be I missed something but as far as I understood this issue is about implementing vscode scm api but Theia doesn't have Source Code Management. Am I right?

@vinokurig
Copy link
Contributor

vinokurig commented Jan 23, 2019

Git extension has to be updated to use this API. The plugin extension then should use new API to implement VS Code SCM API.

@akosyakov Do you mean that Vscode scm api should use existed Git extension?

@vinokurig
Copy link
Contributor

@akosyakov Could you please explain how this issue is related to VSCode Git extension?

@vinokurig
Copy link
Contributor

Vscode uses Scm Service for this Api: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/scm/common/scmService.ts#L128,
Do we need such service?

@vinokurig
Copy link
Contributor

@akosyakov akosyakov self-assigned this Jun 10, 2019
@akosyakov akosyakov added the scm issues related to the source control manager label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves git issues related to git plug-in system issues related to the plug-in system scm issues related to the source control manager vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants