-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support vscode scm api #4103
Comments
Hi, is it expected to be in progress in the nearest time? We need it to launch VsCode pull request plugin: https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github |
If not we can take it, @akosyakov @svenefftinge WDYT? |
The deadline for our related task (eclipse-che/che#11867) is 5-th February |
Nice, please go ahead if you can start working on it now. :) |
Hi I am wondering if it is possible / good strategy to reuse vscode git extension and completely replace the current theia git implementation. WDYT ? |
Eventually, maybe, if there won't be any clients. Before it the current git extension and git VS Code extension should share the same UI and contribution points. |
I guess it depends on #3423 |
@vinokurig It is another way around. |
May be I missed something but as far as I understood this issue is about implementing vscode scm api but Theia doesn't have Source Code Management. Am I right? |
@akosyakov Do you mean that Vscode scm api should use existed Git extension? |
@akosyakov Could you please explain how this issue is related to VSCode Git extension? |
Vscode uses Scm Service for this Api: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/scm/common/scmService.ts#L128, |
Moved the discussion to https://spectrum.chat/?t=951554dc-9fbf-4ad5-b5f2-2a6c07c058f0 |
APIs: https://code.visualstudio.com/api/references/vscode-api#scm
There is VS Code extension for Git: https://github.com/Microsoft/vscode/tree/master/extensions/git
Our SCM UI is bound to Git right now. We need to extract Git-agnostic UI to a new extension. This extension should provide APIs similar to VS Code. Git extension has to be updated to use this API. The plugin extension then should use new API to implement VS Code SCM API.
The text was updated successfully, but these errors were encountered: