Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin-API] Redundant 'CancellationToken' argument is present in each rpc-request #4957

Closed
vinokurig opened this issue Apr 19, 2019 · 2 comments · Fixed by #4967
Closed
Labels
bug bugs found in the application plug-in system issues related to the plug-in system

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Apr 19, 2019

Description

On each rpc-request a new argument 'CancellationToken' is added to the arguments array:
https://github.com/theia-ide/theia/blob/2a2a6010329850e79b508b2133a62749d2d39e05/packages/plugin-ext/src/api/rpc-protocol.ts#L179-L181

It causes a wrong behavior of VsCode Git Extention. On executing some commands, the extension handles received arguments and 'CancellationToken' object influences on the commands result:
https://github.com/Microsoft/vscode/blob/7d39e805fb66a6eac22f19af8bb90f48da863fd5/extensions/git/src/commands.ts#L649-L677

The command handles resourceStates: SourceControlResourceState[] It converts the argument to undefined and adds to uri array. While iterating the array workspace.openTextDocument(uri) with undefined is applied: https://github.com/Microsoft/vscode/blob/7d39e805fb66a6eac22f19af8bb90f48da863fd5/extensions/git/src/commands.ts#L692

Related Commit: 4286ebd
Is needed for #4103

@akosyakov WDYT?

OS and Theia version:

Diagnostics:

@vinokurig vinokurig added the bug bugs found in the application label Apr 19, 2019
@kittaakos
Copy link
Contributor

Possible the same as #4310

@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Apr 19, 2019
@akosyakov
Copy link
Member

ok, then we need to pass a boolean flag to indicate whether the cancellation token should be appended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants