Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complete implementation of commands APIs #4230

Closed
3 tasks done
akosyakov opened this issue Feb 1, 2019 · 0 comments · Fixed by #4264
Closed
3 tasks done

complete implementation of commands APIs #4230

akosyakov opened this issue Feb 1, 2019 · 0 comments · Fixed by #4264
Assignees
@akosyakov
Labels
bug bugs found in the application vscode issues related to VSCode compatibility

Comments

@akosyakov
Copy link
Member

akosyakov commented Feb 1, 2019 •
edited
Loading

  • getCommands
  • registerTextEditorCommand
  • thisArg missing for command registration
@akosyakov akosyakov added bug bugs found in the application vscode issues related to VSCode compatibility labels Feb 1, 2019
@akosyakov akosyakov self-assigned this Feb 1, 2019
akosyakov added a commit that referenced this issue Feb 6, 2019
@akosyakov
fix #4230: complete implementation of command VS Code API
9f2fb97 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Feb 6, 2019
Merged
akosyakov added a commit that referenced this issue Feb 6, 2019
@akosyakov
fix #4230: complete implementation of command VS Code API
4baad33 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 6, 2019
@akosyakov
fix #4230: complete implementation of command VS Code API
31f38ee 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 6, 2019
@akosyakov
fix #4230: complete implementation of command VS Code API
f0516aa 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Feb 7, 2019
@akosyakov
fix #4230: complete implementation of command VS Code API
5550757 
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes for command VS Code API tests eclipse-theia/theia
1 participant
@akosyakov