Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring of a task #5747

Closed
RomanNikitenko opened this issue Jul 18, 2019 · 0 comments · Fixed by #5777
Closed

Configuring of a task #5747

RomanNikitenko opened this issue Jul 18, 2019 · 0 comments · Fixed by #5777
Assignees
@elaihau
Labels
question user / developer questions tasks issues related to the task system

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jul 18, 2019 •
edited
Loading

Description

A task is not displayed in configured tasks section after configuring.
Is it correct behavior?

Reproduction Steps

1.Terminal => Run Task menu, select npm:build and click cog icon (configure task action)
2. You can see that the configuration is copied to tasks.json file and you can edit it
3. Go again to Terminal => Run Task menu
4. You can see that the task still in detected tasks section

Please see the video: https://youtu.be/C5bp8mdSFgM

Diagnostics:
I investigated a little source code and found that:

  • after configuring of the detected task npm:build, it is copied to tasks.json file
  • at reading from tasks.json file the configuration goes to customizations, not to configuredTasksArray
  • at creating Run Task menu configured tasks are taken, not customizations.
  • customizations are used at running of detected task

As result, npm:build task is not displayed in configured tasks section.

So, what's the correct new behavior?

  1. Will configured tasks section display only configurations from tasks.json which don't have 'parent' detected task?
  2. What's the correct new behavior for 'recently used' section for detected and customization configs. I mean use case like described here: Recently used tasks section should respect configured tasks #5067
  3. Are overridden fields from tasks.json applied for a configuration which have 'parent' detected task?

Thanks in advance!
@RomanNikitenko RomanNikitenko added question user / developer questions tasks issues related to the task system labels Jul 18, 2019
This was referenced Jul 18, 2019
Closed
Closed
Closed
Merged
elaihau pushed a commit that referenced this issue Jul 23, 2019
align "task quick open" in Theia with vs code
fad008a 
- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)
- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Jul 23, 2019
Closed
elaihau pushed a commit that referenced this issue Jul 23, 2019
align "task quick open" in Theia with vs code
477f7e8 
- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)
- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Jul 23, 2019
Merged
elaihau pushed a commit that referenced this issue Jul 24, 2019
align "configure task" and "task quick open" with vs code
396b329 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 24, 2019
align "configure task" and "task quick open" with vs code
baab4d6 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 27, 2019
align "configure task" and "task quick open" with vs code
14b89f3 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than the ones used in the task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 28, 2019
align "configure task" and "task quick open" with vs code
29dbe89 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than the ones used in the task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Jul 28, 2019
align "configure task" and "task quick open" with vs code
0fb0b45 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 1, 2019
align "configure task" and "task quick open" with vs code
2fe7262 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
elaihau pushed a commit that referenced this issue Aug 1, 2019
@elaihau
align "configure task" and "task quick open" with vs code
e0d38ee 
- edit the right task.json when clicking "configure task" in multi-root
workspace (fixed #4919)

- in the current Theia, when users configure a detected task, the entire
task config is written into tasks.json, which introduces redundancy.
With this change, only properties that define the detected task, plus `problemMatcher`, are
written into tasks.json. (fixed #5679)

- allow users to override any task properties other than `type`, and those that are used to define the in its task definition.

- `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way.
With this change Theia supports having different ways of task customization in different root folders.

- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747)

- The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719)

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
question user / developer questions tasks issues related to the task system
Projects
None yet
Milestone
No milestone
2 participants
@RomanNikitenko @elaihau