Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emtpy tasks.json are not handled properly #6032

Closed
elaihau opened this issue Aug 25, 2019 · 0 comments · Fixed by #6033
Closed

emtpy tasks.json are not handled properly #6032

elaihau opened this issue Aug 25, 2019 · 0 comments · Fixed by #6033
Assignees
@elaihau
Labels
bug bugs found in the application tasks issues related to the task system

Comments

@elaihau
Copy link
Contributor

elaihau commented Aug 25, 2019

Description

emtpy tasks.json are not handled properly

Reproduction Steps

Peek 2019-08-24 23-04

  1. Open a workspace that has
  • at least one detected task
  • a tasks.json where at least one detected task is customized
  1. Open the "Run task"
  • The customized detected tasks are displayed as "Configured tasks". This is good.
  1. Remove all data from tasks.json. Save changes.
  2. Open the "Run task" again
  • what happens: some detected tasks are displayed as "Configured tasks"
  • what should happen: all detected tasks should be displayed as "detected tasks", as the customizations have been removed from tasks.json

OS and Theia version:
Ubuntu 18.04. Example browser. master branch as of Aug 24 2019 ffcb3fa
@elaihau elaihau added bug bugs found in the application tasks issues related to the task system labels Aug 25, 2019
@elaihau elaihau self-assigned this Aug 25, 2019
elaihau pushed a commit that referenced this issue Aug 25, 2019
support removing all data from tasks.json
024cc89 
- When all data are removed from tasks.json, or data in tasks.json is
corrupted, Theia fails to update tasks that have been loaded into the
memory. This pull request fixes this bug.
- fixes #6032

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
@elaihau elaihau mentioned this issue Aug 25, 2019
Merged
1 task
elaihau pushed a commit that referenced this issue Aug 26, 2019
@elaihau
support removing all data from tasks.json
33cd496 
- When all data are removed from tasks.json, or data in tasks.json is
corrupted, Theia fails to update tasks that have been loaded into the
memory. This pull request fixes this bug.
- fixes #6032

Signed-off-by: Liang Huang <liang.huang@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elaihau elaihau

Labels
bug bugs found in the application tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support removing all data from tasks.json eclipse-theia/theia
1 participant
@elaihau