Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview widget background is transparent causing isues with branding logo #6194

Closed
mjshashank opened this issue Sep 16, 2019 · 0 comments · Fixed by #6196
Closed

Preview widget background is transparent causing isues with branding logo #6194

mjshashank opened this issue Sep 16, 2019 · 0 comments · Fixed by #6196
Labels
bug bugs found in the application preview issues related to the preview

Comments

@mjshashank
Copy link

mjshashank commented Sep 16, 2019 •
edited
Loading

Description

I added a branding extension similar to https://github.com/vince-fugnitto/theia-cpp-branding.

It works fine to the extent the logo is added to the empty panel.

But when I open the preview of a markdown file, the rendered output panel has a transparent background causing the logo to be visible and conflict with the rendered preview.

Reproduction Steps

  1. Add the above extension
  2. Start Theia
  3. Open a markdown file
  4. Click on preview

OS and Theia version:
Theia Version: next

cc: @vince-fugnitto
@AlexTugarev AlexTugarev added bug bugs found in the application preview issues related to the preview labels Sep 16, 2019
vince-fugnitto added a commit that referenced this issue Sep 16, 2019
@vince-fugnitto
Fix transparent preview widget background
4e269b8 
Fixes #6194

- fixes an issue where the preview widget has a transparent background
which causes problems whenever the background has content
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Sep 16, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Sep 17, 2019
@vince-fugnitto
Fix transparent preview widget background
c8f4d3a 
Fixes #6194

- fixes an issue where the preview widget has a transparent background
which causes problems whenever the background has content
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Sep 17, 2019
@vince-fugnitto
Fix transparent preview widget background
b3444e6 
Fixes #6194

- fixes an issue where widgets present in the main area had transparent
backgrounds which interfered with custom branding.
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Sep 19, 2019
@vince-fugnitto
Fix transparent preview widget background
24f77b3 
Fixes #6194

- fixes an issue where widgets present in the main area had transparent
backgrounds which interfered with custom branding.
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
Fix transparent preview widget background
f54ff8b 
Fixes eclipse-theia#6194

- fixes an issue where widgets present in the main area had transparent
backgrounds which interfered with custom branding.
- adjusts the styling of the dockpanel to be more consistent with VSCode

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application preview issues related to the preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[preview] fix transparent preview widget background eclipse-theia/theia
2 participants
@AlexTugarev @mjshashank