Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configuration of debug panel shows wrong suggestions when a new websocket is created #6200

Closed
tom-shan opened this issue Sep 17, 2019 · 3 comments · Fixed by #6205
Closed
Assignees
Labels
bug bugs found in the application critical critical bugs / problems debug issues that related to debug functionality

Comments

@tom-shan
Copy link
Contributor

Description

After the websocket connection is recreated for network problems, clicking Add Configuration of debug panel will only show some useless suggestions.
This problem appears frequently because of my bad network and is very annoying.

right suggestions
image

wrong suggestions after a new websocket is created
image

Reproduction Steps

This issue may be difficult to reproduce in reliable networks, so I use iptables to cut the network connection between the server and client as follows:

#/bin/bash
iptables -I INPUT -p tcp -s {client ip} --dport {connection port} -j DROP
sleep 20
iptables -D INPUT 1

The sleep time should be long enough, otherwise the old websocket connection will be reused and the problem will not be reproduced.
OS and Theia version:
os: centos 7
theia commit id: 1808d78
Diagnostics:

@akosyakov
Copy link
Member

@tom-shan Do you use VS Code extensions for node.js debugging?

@akosyakov akosyakov added bug bugs found in the application debug issues that related to debug functionality labels Sep 18, 2019
@akosyakov akosyakov self-assigned this Sep 18, 2019
@tom-shan
Copy link
Contributor Author

@tom-shan Do you use VS Code extensions for node.js debugging?

No, I did not use any vscode extension.

@akosyakov akosyakov added the critical critical bugs / problems label Sep 18, 2019
@akosyakov
Copy link
Member

It's a regression since restart skips now if a server is not running, but it does not play nicely with reconnection. I will do a PR promptly. cc @AlexTugarev

akosyakov added a commit that referenced this issue Sep 18, 2019
Since restart skips if a server is not running, on reconnection a server has to be restarted forcefully if it was running before.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Sep 18, 2019
Since restart skips if a server is not running, on reconnection a server has to be restarted forcefully if it was running before.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
… reconnect

Since restart skips if a server is not running, on reconnection a server has to be restarted forcefully if it was running before.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application critical critical bugs / problems debug issues that related to debug functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants