Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown preview cannot open relative file links #6396

Closed
akosyakov opened this issue Oct 16, 2019 · 0 comments · Fixed by #6403
Closed

markdown preview cannot open relative file links #6396

akosyakov opened this issue Oct 16, 2019 · 0 comments · Fixed by #6403
Assignees
@akosyakov
Labels
bug bugs found in the application preview issues related to the preview

Comments

@akosyakov
Copy link
Member

It's a regression, probably caused by a recent version of vscode-uri.
@akosyakov akosyakov added bug bugs found in the application preview issues related to the preview labels Oct 16, 2019
@akosyakov akosyakov self-assigned this Oct 16, 2019
akosyakov added a commit that referenced this issue Oct 16, 2019
@akosyakov
[markdown-preview] fix #6396: resolve relative links properly
68d0652 
Latest version of vscode-uir makes sure that URI always has a scheme  or fall backs to `file` scheme and that URI is always absolute by adding leading `/` to the relative path. It broke an assumption that a URI can be relative in the markdown preview.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Oct 16, 2019
Merged
1 task
akosyakov added a commit that referenced this issue Oct 17, 2019
@akosyakov
[markdown-preview] fix #6396: resolve relative links properly
5cd87bf 
Latest version of vscode-uir makes sure that URI always has a scheme  or fall backs to `file` scheme and that URI is always absolute by adding leading `/` to the relative path. It broke an assumption that a URI can be relative in the markdown preview.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[markdown-preview] fix eclipse-theia#6396: resolve relative links pro…
9334319 
…perly

Latest version of vscode-uir makes sure that URI always has a scheme  or fall backs to `file` scheme and that URI is always absolute by adding leading `/` to the relative path. It broke an assumption that a URI can be relative in the markdown preview.

Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akosyakov akosyakov

Labels
bug bugs found in the application preview issues related to the preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[markdown-preview] resolve relative links properly eclipse-theia/theia
1 participant
@akosyakov