Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scm] single-click nodes in the scm widget should open diff-editor #6479

Closed
vince-fugnitto opened this issue Nov 1, 2019 · 0 comments · Fixed by #6481
Closed

[scm] single-click nodes in the scm widget should open diff-editor #6479

vince-fugnitto opened this issue Nov 1, 2019 · 0 comments · Fixed by #6481
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager ui/ux issues related to user interface / user experience

Comments

@vince-fugnitto
Copy link
Member

Description

Currently, when attempting to open a diff-editor for a given change in the SCM widget, a double-click is required by users. As a user, I'd expect that diff-editor should be opened using a single-click. In addition, performing a single-click does nothing.

How to test

  1. start the application
  2. perform a change under a workspace which is under Git version control
  3. navigate to the SCM widget
  4. single-click the change in the SCM widget (nothing occurs)
  5. double-click the change in the SCM widget (the diff-editor is opened)

Additional Information

  • VS Code uses a single-click to open diff-editors from the SCM widget.
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves ui/ux issues related to user interface / user experience scm issues related to the source control manager labels Nov 1, 2019
vince-fugnitto added a commit that referenced this issue Nov 1, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
4943eeb 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered on `single-click` rather than
`double-click`. This aligns with a similar behavior present
in VS Code.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto mentioned this issue Nov 1, 2019
Merged
1 task
vince-fugnitto added a commit that referenced this issue Nov 7, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
30c229e 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 7, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
f7b11c7 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 7, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
ae4b83d 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 8, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
37fac13 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 8, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
f9a9e16 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 8, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
3dead8b 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto added a commit that referenced this issue Nov 11, 2019
@vince-fugnitto
Open 'diff-editors' with a single-click
a9c6ed4 
Fixes #6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vince-fugnitto @akosyakov
Open 'diff-editors' with a single-click
a85aef8 
Fixes eclipse-theia#6479

- updated the opening of `diff-editors` from the `scm`
widget to be triggered based on the preference `workbench.list.openMode`.
- updated the preference name `list.openMode` to `workbench.list.openMode`.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves scm issues related to the source control manager ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[scm] open 'diff-editors' with a single-click eclipse-theia/theia
1 participant
@vince-fugnitto