Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui/ux][tree] Help the tree indentation with vertical lines, mimic VS Code #6586

Closed
kittaakos opened this issue Nov 20, 2019 · 0 comments · Fixed by #8298
Closed

[ui/ux][tree] Help the tree indentation with vertical lines, mimic VS Code #6586

kittaakos opened this issue Nov 20, 2019 · 0 comments · Fixed by #8298
Labels
enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience

Comments

@kittaakos
Copy link
Contributor

Description

From time to time, it is hard to identify the indentation in the tree. We used to have a larger indentation, now we have a small one to adjust Theia's styles to VS Code. Besides using small indentations, VS Code also shows vertical lines in the tree which is cool. Let's do the same.

See the attached screenshot:
Screen Shot 2019-11-20 at 10 01 53

and the :hover behavior too:
screencast 2019-11-20 10-02-15

Reproduction Steps

OS and Theia version:

Diagnostics:
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves tree issues related to the tree (ex: tree widget) labels Nov 20, 2019
@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer ui/ux issues related to user interface / user experience labels Nov 20, 2019
@kaiyue0329 kaiyue0329 mentioned this issue Jan 17, 2020
Closed
1 task
@kaiyue0329 kaiyue0329 mentioned this issue Feb 21, 2020
Closed
1 task
@kaiyue0329 kaiyue0329 mentioned this issue Jul 14, 2020
Closed
1 task
akosyakov added a commit that referenced this issue Aug 4, 2020
@akosyakov
fix #6586: tree indent guidelins
cea71eb 
Co-authored-By: Kaiyue Pan <kaiyue.pan@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
@akosyakov akosyakov mentioned this issue Aug 4, 2020
Merged
1 task
akosyakov added a commit that referenced this issue Aug 4, 2020
@akosyakov
fix #6586: tree indent guidelines support
04be1dd 
Co-authored-By: Kaiyue Pan <kaiyue.pan@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 4, 2020
@akosyakov
fix #6586: tree indent guidelines support
8903412 
Co-authored-By: Kaiyue Pan <kaiyue.pan@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
akosyakov added a commit that referenced this issue Aug 5, 2020
@akosyakov
fix #6586: tree indent guidelines support
6086b28 
Co-authored-By: Kaiyue Pan <kaiyue.pan@ericsson.com>
Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer tree issues related to the tree (ex: tree widget) ui/ux issues related to user interface / user experience
Projects
None yet
Milestone
No milestone
3 participants
@kittaakos @akosyakov @vince-fugnitto