-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vscode] icons for editor decorators cannot be fetched #6661
Comments
@DanTup how do you create an icon path btw? Do you call any VS Code APIs for it? |
It's just a normal file URI:
There's a VS code sample for using decorations at https://github.com/Microsoft/vscode-extension-samples/tree/master/decorator-sample that you could use (and just add a |
VS Code extensions are using absolute paths to load editor icons. It does not work in remote environments. Instead we rewrite files URIs to external URIs to make it work. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
VS Code extensions are using absolute paths to load editor icons. It does not work in remote environments. Instead we rewrite files URIs to external URIs to make it work. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
…l URIs VS Code extensions are using absolute paths to load editor icons. It does not work in remote environments. Instead we rewrite files URIs to external URIs to make it work. Signed-off-by: Anton Kosyakov <anton.kosyakov@typefox.io>
The issue is that icons are provided as absolute fs paths: gitpod-io/gitpod#958 It does not work in the browser context. We have to translate such paths to http URLs to make it work.
@DanTup Could you share how it can be tested?
The text was updated successfully, but these errors were encountered: