Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] XSS vulnerability in browser sidebar #6987

Closed
caseyflynn-google opened this issue Jan 28, 2020 · 0 comments · Fixed by #6988
Closed

[browser] XSS vulnerability in browser sidebar #6987

caseyflynn-google opened this issue Jan 28, 2020 · 0 comments · Fixed by #6988
Assignees
@caseyflynn-google
Labels
security issues related to security

Comments

@caseyflynn-google
Copy link
Contributor

Description

There is an XSS vulnerability in the side-panel-toolbar

Reproduction Steps

  1. Create a folder outside of Theia named "<style onload=alert(0)>"
    1.a Example: mkdir \<style\ onload=alert\(0\)\>
  2. In Theia click FIle -> Open Workspace
  3. Select the directory named <style onload=alert(0)>
  4. Open the file explorer

Outcome: Theia executes the XSS
Side effect: Theia will continue to execute the XSS on refresh until the workspace is changed.

OS and Theia version:
Linux
Theia 0.14.0

Diagnostics:
@caseyflynn-google caseyflynn-google added the security issues related to security label Jan 28, 2020
@caseyflynn-google caseyflynn-google self-assigned this Jan 28, 2020
caseyflynn-google added a commit to caseyflynn-google/theia that referenced this issue Jan 28, 2020
@caseyflynn-google
fix eclipse-theia#6987 XSS vulnerability in browser sidebar
41281f4 
Change simply updates innerHtml to innerText to ensure user supplied
content does not impact the dom.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
@caseyflynn-google caseyflynn-google mentioned this issue Jan 28, 2020
Merged
1 task
caseyflynn-google added a commit that referenced this issue Jan 29, 2020
@caseyflynn-google
fix #6987 XSS vulnerability in browser sidebar
a6d565e 
Change simply updates innerHtml to innerText to ensure user supplied
content does not impact the dom.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@caseyflynn-google @akosyakov
fix eclipse-theia#6987 XSS vulnerability in browser sidebar
17a52c8 
Change simply updates innerHtml to innerText to ensure user supplied
content does not impact the dom.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@caseyflynn-google
fix eclipse-theia#6987 XSS vulnerability in browser sidebar
1b80dac 
Change simply updates innerHtml to innerText to ensure user supplied
content does not impact the dom.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
@luigigubello luigigubello mentioned this issue Nov 30, 2020
Closed
@luigigubello luigigubello mentioned this issue Dec 16, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caseyflynn-google caseyflynn-google

Labels
security issues related to security
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #6987 XSS vulnerability in browser sidebar caseyflynn-google/theia
1 participant
@caseyflynn-google