Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multi-root] Relative paths in multi-root setting are not resolved when opening a Terminal #7597

Closed
corneliusludmann opened this issue Apr 17, 2020 · 0 comments · Fixed by #7598
Closed

[multi-root] Relative paths in multi-root setting are not resolved when opening a Terminal #7597

corneliusludmann opened this issue Apr 17, 2020 · 0 comments · Fixed by #7598
Labels
bug bugs found in the application multi-root issues related to multi-root support terminal issues related to the terminal

Comments

@corneliusludmann
Copy link
Contributor

Description

When you define a multi-root workspace with relative paths like ../../workspace/ the path is not resolved when you open a terminal. You can see it in the following screenshot in the menu as well as in the terminal view.

image

Reproduction Steps

  • Start Theia
  • Create a muli-root workspace like this:
{
   "folders": [
      {
         "path": ""
      },
      {
         "path": "../../workspace"
      }
   ],
   "settings": {}
}
  • Select Open New Terminal in Command Palette
  • See that the URI is not resolved, e.g. ../.. is not resolved

OS and Theia version:

  • Version: ebf7b78
  • Started in Gitpod
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 17, 2020
@corneliusludmann
Use normalized URI in Terminal CWD selector
90cc429 
If you have configured a workspace folder like
```
"path": "../../workspace"
```
you get a Terminal for URI `/workspace/theia/../../workspace` instead of `/workspace`. This commit fixes this by using a normalized path in the terminal cwd selector.

Fixes eclipse-theia#7597
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 17, 2020
@corneliusludmann
Use normalized URI in Terminal CWD selector
1c9143b 
If you have configured a workspace folder like
```
"path": "../../workspace"
```
you get a Terminal for URI `/workspace/theia/../../workspace` instead of `/workspace`. This commit fixes this by using a normalized path in the terminal cwd selector.

Fixes eclipse-theia#7597
@corneliusludmann corneliusludmann mentioned this issue Apr 17, 2020
Merged
1 task
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 17, 2020
@corneliusludmann
Use normalized URI in Terminal CWD selector
375a0b7 
If you have configured a workspace folder like
```
"path": "../../workspace"
```
you get a Terminal for URI `/workspace/theia/../../workspace` instead of `/workspace`. This commit fixes this by using a normalized path in the terminal cwd selector.

Fixes eclipse-theia#7597

Signed-off-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
@akosyakov akosyakov added bug bugs found in the application multi-root issues related to multi-root support terminal issues related to the terminal labels Apr 17, 2020
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 17, 2020
@corneliusludmann
Normalize paths of workspace roots
205d7ba 
This avoids having workspace roots like /workspace/../../workspace when having relative paths in the workspace roots configuration.

Fixes eclipse-theia#7597

Signed-off-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 21, 2020
@corneliusludmann
Normalize paths of workspace roots
89e25c0 
This avoids having workspace roots like /workspace/../../workspace when having relative paths in the workspace roots configuration.

Fixes eclipse-theia#7597

Signed-off-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
corneliusludmann added a commit to corneliusludmann/theia that referenced this issue Apr 21, 2020
@corneliusludmann
Normalize paths of workspace roots
40c6322 
This avoids having workspace roots like /workspace/../../workspace when having relative paths in the workspace roots configuration.

Fixes eclipse-theia#7597

Signed-off-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
akosyakov pushed a commit that referenced this issue Apr 24, 2020
@corneliusludmann @akosyakov
Normalize paths of workspace roots
669ad8b 
This avoids having workspace roots like /workspace/../../workspace when having relative paths in the workspace roots configuration.

Fixes #7597

Signed-off-by: Cornelius A. Ludmann <cornelius.ludmann@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application multi-root issues related to multi-root support terminal issues related to the terminal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workspace: normalize paths of workspace roots corneliusludmann/theia
2 participants
@akosyakov @corneliusludmann