Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new menu item in the output view context menu #7912

Closed
lmcbout opened this issue May 27, 2020 · 4 comments
Closed

Add new menu item in the output view context menu #7912

lmcbout opened this issue May 27, 2020 · 4 comments
Assignees
@salkin-naj
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help output issues related to the output

Comments

@lmcbout
Copy link
Contributor

lmcbout commented May 27, 2020 •
edited by vince-fugnitto
Loading

Feature Description:

Following issue #7570 , I think it would be nice to have in the context menu an entry: "Copy all" to copy all the data from that output channel or "Select all"
@vince-fugnitto vince-fugnitto added the output issues related to the output label May 27, 2020
@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help labels May 28, 2020
@kittaakos
Copy link
Contributor

"Copy all" to copy all the data from that output channel or "Select all"

Probably we do not need both. You can select all with Ctrl/⌘+A, and copy with Ctrl/⌘+C. I do not see a reason having "Select All" as a menu item. Once you have triggered select all, you will copy, it's read-only. Let's not pollute the context menu just because we can add one more command. "Copy All" could be useful though.

@lmcbout
Copy link
Contributor Author

lmcbout commented May 28, 2020

I don't think we need both, only one of them is enough

@salkin-naj
Copy link
Contributor

I am interested in working on this issue. Did I read your conversation correctly, you want a 'Copy All' option, but no 'Select All'?

@kittaakos
Copy link
Contributor

I am interested in working on this issue.

Sounds great, go ahead!

Did I read your conversation correctly, you want a 'Copy All' option, but no 'Select All'?

Correct 👍

salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 19, 2020
@salkin-naj
'Copy all' for context menu in output view
95a44a5 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard.

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 23, 2020
@salkin-naj
'Copy all' for context menu in output view
6e7386d 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard,
using the clipboardService

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 24, 2020
@salkin-naj
'Copy all' for context menu in output view
3342e53 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard,
using the clipboardService

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 25, 2020
@salkin-naj
'Copy all' for context menu in output view
dbf7cb4 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard,
using the clipboardService

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 25, 2020
@salkin-naj
'Copy all' for context menu in output view
e196e15 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard,
using the ClipboardService.

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
salkin-naj added a commit to salkin-naj/theia that referenced this issue Jun 26, 2020
@salkin-naj
'Copy all' for context menu in output view
2cbc217 
This adds another option to the context menu of the output view,
which copies everything in the selected channel into the clipboard,
using the ClipboardService.

Closes eclipse-theia#7912

Signed-off-by: Jan-Niklas Spangenberg <jan-niklas.spangenberg@gmx.de>
@kittaakos kittaakos mentioned this issue Dec 8, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salkin-naj salkin-naj

Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help output issues related to the output
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lmcbout @kittaakos @akosyakov @vince-fugnitto @salkin-naj