Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when setting the app name for electron #8701

Open
kittaakos opened this issue Nov 3, 2020 · 0 comments
Open

Regression when setting the app name for electron #8701

kittaakos opened this issue Nov 3, 2020 · 0 comments
Labels
bug bugs found in the application electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

Bug Description:

We do not set the app name anymore. It was:

theia/dev-packages/application-manager/src/generator/frontend-generator.ts

Lines 144 to 146 in 0159cd5

// Explicitly set the app name to have better menu items on macOS. ("About", "Hide", and "Quit")
// See: https://github.com/electron-userland/electron-builder/issues/2468
app.setName(applicationName);

We lost the feature with: #7964

Steps to Reproduce:

Additional Information

  • Operating System:
  • Theia Version:
@vince-fugnitto vince-fugnitto added bug bugs found in the application electron issues related to the electron target labels Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @vince-fugnitto