Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the electron app name. #6726

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

kittaakos
Copy link
Contributor

To have better menu items on macOS.
("About", "Hide", and "Quit")

Before:
Screen Shot 2019-12-09 at 20 25 45

After:
Screen Shot 2019-12-09 at 20 27 57

Signed-off-by: Akos Kitta kittaakos@typefox.io

What it does

How to test

Review checklist

Reminder for reviewers

To have better menu items on macOS.
("About", "Hide", and "Quit")

Signed-off-by: Akos Kitta <kittaakos@typefox.io>
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 😃

@vince-fugnitto vince-fugnitto added the electron issues related to the electron target label Dec 9, 2019
@kittaakos kittaakos merged commit 0159cd5 into master Dec 9, 2019
@kittaakos kittaakos deleted the electron-set-app-name branch December 9, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants