Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webcontents ID in isSender check #11654

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes #11600 according to @kittaakos suggestion.

How to test

  1. Run the electron example: (We can see the window 1)
  2. Reload the window: (Reload the window 1)
  3. Click the New Window in the menu, and it does work.

  1. Open a file and make it dirty.
  2. Click to exit the application.
  3. See a dialog prompting you for whether you want to exit.
  4. Click no
  5. The window should remain open.

Review checklist

Reminder for reviewers

Co-authored-by: Colin Grant <colin.grant@ericsson.com>
Co-authored-by: Akos Kitta <a.kitta@arduino.cc>
@colin-grant-work colin-grant-work added the electron issues related to the electron target label Sep 8, 2022
@kittaakos
Copy link
Contributor

Thank you for the prompt fix!

How to test

  1. Run the electron example: (We can see the window 1)
  2. Reload the window: (Reload the window 1)
  3. Click the New Window in the menu, and it does work.

It does not work for me. I have checked out 4a646eb and built it locally. It also does not work when opening a new window with +Shift+N. I am investigating what's going on.

steps_001.mp4

@kittaakos
Copy link
Contributor

This change fixes the issue for me. I think the window multiplexer should be removed from the map when the window reloads/closes.

@colin-grant-work
Copy link
Contributor Author

Since this doesn't seem to have improved anything, I'll close it. @kittaakos, if you'd like to make a PR with your changes, feel free.

@kittaakos
Copy link
Contributor

It fixes the reload error described in #11600 for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create new window after reload the current empty window
2 participants