Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin localization service does not await on init #11853

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Plugin localization service does not await on init #11853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/plugin-ext/src/hosted/node/hosted-plugin-localization-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { DeployedPlugin, Localization as PluginLocalization, PluginIdentifiers }
import { URI } from '@theia/core/shared/vscode-uri';
import { EnvVariablesServer } from '@theia/core/lib/common/env-variables';
import { BackendApplicationContribution } from '@theia/core/lib/node';
import { Disposable } from '@theia/core';
import { Disposable, MaybePromise } from '@theia/core';
import { Deferred } from '@theia/core/lib/common/promise-util';

export interface VSCodeNlsConfig {
Expand Down Expand Up @@ -56,10 +56,10 @@ export class HostedPluginLocalizationService implements BackendApplicationContri
*/
ready = this._ready.promise;

async initialize(): Promise<void> {
const cacheDir = await this.getLocalizationCacheDir();
await fs.emptyDir(cacheDir);
this._ready.resolve();
initialize(): MaybePromise<void> {
this.getLocalizationCacheDir()
.then(cacheDir => fs.emptyDir(cacheDir))
.then(() => this._ready.resolve());
}

deployLocalizations(plugin: DeployedPlugin): void {
Expand Down