-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split license files for better recognition #12424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Mark!
@msujew : In the file LICENSE (version 1.36.0) the was the GPL-2.0-with-classpath-exception (see line 625 ff). Now you split it. This is fine. But you copied a special classpath exception to LICENSE-GPL (see line 343 ff). Why did you add a special license from Oracle to Theia? I have searched and only in this file the name ORACLE appears. Maybe you should replace this text by the original one from spdx.org and use the SPDX shot identifier GPL-2.0-with-classpath-exception for this. |
Thank you @SpessartZiegler - it's indeed wrong to have "GPL-2.0" detected for this repo. I will look into your suggestions! |
@msujew I think we may have the root cause of the GitHub license detection issue: #12424 (comment) . The SPDX we've been using in various I will open an issue about this. |
PR #12584 |
update: |
What it does
GitHub is using
licensee
to identify license information in repositories. The project identifies licenses on a per file basis and therefore has trouble with our double-license-in-one-file format.I've split the
LICENSE
file intoLICENSE-GPL
andLICENSE-EPL
, so that GitHub can correctly identify them. See this test repo where GitHub is able to successfully identify the two used licenses.How to test
Merge this PR and assert that the license information in the repository is correctly updated.
Review checklist
Reminder for reviewers