Fix TreeView.reveal() behavior. #12489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
vince-fugnitto
approved these changes
May 16, 2023
tsmaeder
added a commit
to tsmaeder/theia
that referenced
this pull request
May 23, 2023
Fixes eclipse-theia#12488 contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the
TreeView.revealbehavior. The behavior was broken when we moved to a new scheme for generatingTreeNodeids fromTreeItems, In addition, the reveal flags (select, focus, reveal) were not passed to the front end.Fixes #12488
Contributed on behalf of STMicroelectronics
How to test
Make sure the failure case from the related issue now works. In addition, I used the procedure from #8783 to guard against regressions.
Review checklist
Reminder for reviewers