Resize terminal process after resizing widget #13281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #13174
Resize the terminal process in the debounced
doResizeTerminal
(after the terminal widget has the new size) instead of directly in theonUpdateRequest
.Contributed on behalf of Elektrobit Automotive GmbH.
How to test
packages/terminal/src/browser/terminal-widget-impl.ts:604
(i.e. inonUpdateRequest
) and stepping through always reproduces the issue.tput cols
andtput lines
, see that it is the incorrect size (defaults to 80 and 24, instead of the real size of the terminal widget after it is fix into the view)With this PR step 3 and 4 should behave correctly. I.e. the size of the terminal is correct after opening, without having to resize.
Follow-ups
Review checklist
Reminder for reviewers