Support specifying the port of a remote SSH connection #13296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Uses
new URL(<host>)
to parse the host specified by the user and pass onurl.hostname
andurl.port
when establishing the SSH connection. This way we enable users to specify the port of the remote SSH server.Contributed on behalf of STMicroelectronics.
Fixes #13295
How to test
2222
withdocker run -d -p 2222:22 ssh-container
user@localhost:2222
Test whether specifying no port, e.g.
user@localhost
still works.Follow-ups
N/A
Review checklist
Reminder for reviewers