Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show decorations in the editor tabs (#13301) #13371

Merged

Conversation

dhuebner
Copy link
Member

@dhuebner dhuebner commented Feb 9, 2024

What it does

As described in #13301 there were no git status indication in the editor tabs. Now all decorations contributed to the DecorationsService are rendered in tabs that owned by a Navigatable Widget. This currently includes SCM (git) and Problem decorations.

Rendering is controlled with workbench.editor.decorations.badges preference.

How to test

Open en example workspace, produce some SCM changes and errors. You should see tail decoration appearing in the editor tabs similar to the navigator.

Bildschirmfoto 2024-02-09 um 14 04 13

Follow-ups

Review checklist

Reminder for reviewers

packages/core/src/browser/shell/tab-bar-decorator.ts Outdated Show resolved Hide resolved
packages/core/src/browser/shell/tab-bar-decorator.ts Outdated Show resolved Hide resolved
packages/core/src/browser/shell/tab-bar-decorator.ts Outdated Show resolved Hide resolved
packages/core/src/browser/shell/tab-bars.ts Outdated Show resolved Hide resolved
@dhuebner
Copy link
Member Author

dhuebner commented Feb 9, 2024

@msujew
Thanks for the re-view. All suggestion were applied.

@dhuebner dhuebner force-pushed the huebner/editortab-decorator-13301 branch from 7c73dbe to f1dc185 Compare February 16, 2024 09:02
@dhuebner dhuebner force-pushed the huebner/editortab-decorator-13301 branch from f1dc185 to 997d84e Compare February 16, 2024 09:03
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a minor issue, see below 👍

packages/core/src/browser/shell/tab-bars.ts Outdated Show resolved Hide resolved
@dhuebner dhuebner force-pushed the huebner/editortab-decorator-13301 branch from 997d84e to 3a795e1 Compare February 21, 2024 08:58
@dhuebner
Copy link
Member Author

@msujew
I've adjusted the code like suggested. Thank you for the re-view!

This was referenced Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

No git status indication in the editor tab
3 participants