Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always consider the "passthrough" commmand enabled for keybindings #13564

Merged

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Apr 4, 2024

What it does

Theia has a "passthrough" command that is supposed to mark occasions where keystrokes are supposed to be passed to the target widget instead of being handled by the keybinding infrastructure. We recently added a check whether a keybinding has an enabled command handler to be considered active. But since the "passthrough" command has no handler, it was always considered disabled. This PR considers the passthrough command as always enabled.

Fixes #13560

Contributed on behalf of STMicroelectronics

How to test

Make sure ctrl-c aborts running tasks in the terminal. Make sure ctrl-c still works to copy text/files, etc elsewhere.

Follow-ups

Review checklist

Reminder for reviewers

Fixes eclipse-theia#13560

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Apr 4, 2024

@jonah-iden could you make sure your recent notebook command fixes are not broken by this one?

@jonah-iden
Copy link
Contributor

sure I'll take a look later today

Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Operations in the terminal are cancellable again and other copy+paste operations don't seem to be affected.
From my pov we can merge this when the notebook commands work as well.

@jonah-iden
Copy link
Contributor

@tsmaeder seems like everything still works correctly for the notrebooks

@tsmaeder tsmaeder merged commit 740fae9 into eclipse-theia:master Apr 4, 2024
14 checks passed
jfaltermeier pushed a commit that referenced this pull request Apr 5, 2024
…13564)

Fixes #13560

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@jfaltermeier jfaltermeier added this to the 1.49.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Running command in terminal cannot be canceled
3 participants