Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show short title for notebook toolbar commands #13586

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Show short title for notebook toolbar commands #13586

merged 1 commit into from
Apr 10, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 10, 2024 •
edited
Loading

What it does

Aligns Theia's rendering behavior for the commands contributed to the interactive/toolbar menu to vscode.

previously

image

now

image

vscode

image

How to test

  1. Open a Jupyter notebook
  2. Confirm that the commands contributed by Jupyter use their shortTitles.

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Apr 10, 2024
@msujew msujew requested a review from jonah-iden April 10, 2024 13:50
jonah-iden
jonah-iden approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good works great. Now the only thing missing from the main toolbar would be the dynamic increasing/decreasing of visible items and adding the others to the ... menu. But thats for later

@msujew msujew merged commit 635eb5b into master Apr 10, 2024
14 checks passed
@msujew msujew deleted the msujew/notebook-short-titles branch April 10, 2024 19:14
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonah-iden jonah-iden jonah-iden approved these changes

Assignees
No one assigned
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience vscode issues related to VSCode compatibility
Projects
PR Backlog
Archived in project
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
2 participants
@msujew @jonah-iden