Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook output scrolling and text rendering #14016

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

msujew
Copy link
Member

@msujew msujew commented Aug 6, 2024

What it does

Fixes two issues related to scrolling in notebooks:

  1. When scrolling down while the cursor hovers over output text, the scrolling is no longer interrupted.
  2. When rendering too much text, the "scrollable element" is actually scrollable and not just a very long text element.

How to test

  1. Create a python notebook file and create this cell:
for i in range(1,100): 
    print('g' + str(i))
  1. Run the cell. Hover over some text within the generated output and scroll down. The content within the notebook should successfully scroll down.
  2. Click on the scrollable element link in the bottom of the rendered text. It should create a scrollable element that is similar in size to the original rendered text.

This PR also fixes a few minor rendering issues related to missing CSS in output webviews.

Review checklist

Reminder for reviewers

@msujew msujew added the notebook issues related to notebooks label Aug 6, 2024
@msujew msujew requested a review from jbicker August 6, 2024 12:12
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@msujew msujew merged commit 1e5fb53 into master Aug 6, 2024
14 checks passed
@msujew msujew deleted the msujew/notebook-scrolling branch August 6, 2024 15:59
@github-actions github-actions bot added this to the 1.53.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants